Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS padding missing from asset view #2488

Closed
nathank1989 opened this issue Aug 25, 2016 · 10 comments
Closed

CSS padding missing from asset view #2488

nathank1989 opened this issue Aug 25, 2016 · 10 comments
Assignees
Labels
✋ bug Confirmed bug
Milestone

Comments

@nathank1989
Copy link

Expected Behavior (or desired behavior if a feature request)

With imagick set as Image Library in .env, upload image and save asset.


Actual Behavior

Error: ImageMagick module not available with this PHP installation.


Please confirm you have done the following before posting your bug report:


Please provide answers to these questions before posting your bug report:

  • Version of Snipe-IT you're running v3.3.0-3-g7ef4f23
  • What OS and web server you're running Snipe-IT on CENTOS 6.8 x86_64 virtuozzo Linux 2.6.32-042stab108.1 Fix depreciation math #1 SMP Thu Apr 23 19:17:11 MSK 2015 x86_64 x86_64 x86_64 GNU/Linux
  • What method you used to install Snipe-IT (install.sh, manual installation, docker, etc) Manual/Git-clone
  • If you're getting an error in your browser, include that error: ImageMagick module not available...
  • What specific Snipe-IT page you're on, and what specific element you're interacting with to trigger the error Asset Edit
  • If a stacktrace is provided in the error, include that too.
  • Any errors that appear in your browser's error console. No
  • Confirm whether the error is reproduceable on the demo. Not reproducable
  • Include any additional information you can find in app/storage/logs and your webserver's logs.
  • Include what you've done so far in the installation, and if you got any error messages along the way.
  • Indicate whether or not you've manually edited any data directly in the database No.

I installed imagick.so via this method:
Install imagick on CentOS
But instead I used echo "extension=imagick.so" >/opt/cpanel/ea-php56/root/etc/php.d/imagick.ini"
My phpinfo lists: /opt/cpanel/ea-php56/root/etc/php.d/imagick.ini
INI:
extension=imagick.so

# convert -version
Version: ImageMagick 6.7.2-7 2016-06-16 Q16 http:https://www.imagemagick.org
Copyright: Copyright (C) 1999-2011 ImageMagick Studio LLC
Features: OpenMP

What, pray-tell, am I doing wrong?

@nathank1989 nathank1989 changed the title ImageMagick module not available with this PHP installation despite imagick.so listed in PHPInfo() ImageMagick module not available with this PHP installation despite imagick.ini listed in PHPInfo() Aug 25, 2016
@uberbrady
Copy link
Collaborator

huh. That sounds like it should work, I think?

First off - and it's a stupid question, but I have to ask it - can you reboot your webserver to make sure it 'took' the changes?

Next, let's make sure your PHP actually has the imageMagick library working - try: php -v and either pipe that through grep or just visually page through the results - looking for something where it says it has ImageMagick support enabled. If all you see is that reference to imagick.ini that may not be enough.

@nathank1989
Copy link
Author

nathank1989 commented Aug 25, 2016

Whelp php -v | grep imagick yields nothing....
here's the link to my php info

snipeit.ssdcougars.tv/phpinfo.php

@snipe
Copy link
Owner

snipe commented Aug 25, 2016

It looks like you already have GD support, so why not just switch your driver to gd in the env file?

@snipe
Copy link
Owner

snipe commented Aug 25, 2016

(Also make sure you delete that info file when we're done here)

@nathank1989
Copy link
Author

Of course I'll be sure to delete that file ;)
But I'd prefer to use IM because I have heard it is more flexible, but if I can't get it working then I will use gd, it works but doesn't seem to resize the images properly.

@snipe
Copy link
Owner

snipe commented Aug 25, 2016

The library we use for image resizing should be pretty agnostic. If it's not resizing images correctly, that's probably something that would happen regardless of imagemagick vs gd, because it's probably a bug on our end.

@nathank1989
Copy link
Author

Ahhh, I see.
For an Asset image, what are the intended dimensions for an uploaded image?

@snipe
Copy link
Owner

snipe commented Aug 25, 2016

Image::make($image)->resize(500, 500, function ($constraint) {

So 500x500, it seems

@nathank1989
Copy link
Author

nathank1989 commented Aug 25, 2016

Oh? Ok, well then I guess everything is working. :) 👍
I had uploaded an image and it fits outside the bounds of the asset page.
http:https://imgur.com/a/X24oF

But, it DID size down from 2560x1440 to 500x281. It just didn't quite fit on the page.
EDIT: I also have a smaller monitor. When I view it on a larger monitor in our edit lab it fits.
I could adjust the value to 400, 400 but honestly it's no big deal. As long as my images are being resized on upload, that's all I cared about.

Thanks @snipe ! I really appreciate your time!

@snipe
Copy link
Owner

snipe commented Aug 25, 2016

That sounds like a CSS issue, not a GD or ImageMagick issue

@snipe snipe changed the title ImageMagick module not available with this PHP installation despite imagick.ini listed in PHPInfo() CSS padding missing from model view Aug 30, 2016
@snipe snipe changed the title CSS padding missing from model view CSS padding missing from asset view Aug 30, 2016
@snipe snipe closed this as completed Aug 30, 2016
@snipe snipe added this to the v3.4.0 milestone Aug 31, 2016
@snipe snipe added the ✋ bug Confirmed bug label Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✋ bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

3 participants