Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: drop uses of test-snapd-curl where possible, replace with snap debug api #14152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bboozzoo
Copy link
Collaborator

@bboozzoo bboozzoo commented Jul 2, 2024

This builds on top of #14116 which add snap debug api. I've updated the tests to not use test-snapd-curl where possible. We still use jq quite a bit, and given the prettified output of snap debug api, perhaps there's a way to skip that too.

@bboozzoo bboozzoo added ⛔ Blocked Run nested The PR also runs tests inluded in nested suite labels Jul 2, 2024
@github-actions github-actions bot added the Run Nested -auto- Label automatically added in case nested tests need to be executed label Jul 2, 2024
@bboozzoo bboozzoo force-pushed the bboozzoo/drop-test-snapd-curl branch from 706d667 to a8c3cb1 Compare July 2, 2024 12:12
Update tests to use `snap debug api` whenever possible.

Signed-off-by: Maciej Borzecki <[email protected]>
@bboozzoo bboozzoo force-pushed the bboozzoo/drop-test-snapd-curl branch from a8c3cb1 to 57187b8 Compare July 4, 2024 05:36
@bboozzoo bboozzoo marked this pull request as ready for review July 4, 2024 05:36
Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! All the changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Nested -auto- Label automatically added in case nested tests need to be executed Run nested The PR also runs tests inluded in nested suite
Projects
None yet
2 participants