Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] interfaces: add apu interface #14072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Asalle
Copy link

@Asalle Asalle commented Jun 12, 2024

Hi all,

As you may know, in recent years we have observed an increase of processing units dedicated to AI/ML provided by various vendors. They are usually accesssible under /dev/UNIT_NAME and to gain access to it in strict mode, we require a new interface. Unfortunately, there is little standartization at the time for the names of these units (see this DLP table), so we can't give access to the entire family of devices using a single interface (like it does for fpgas).

This is a WIP MR aiming to add an interface for Meditek APU (AI Processing Unit)
(more info on specific mediatek device and APU)

cc: @EthanHsieh

Copy link

Hey! undefined has not signed the Canonical CLA which is required to get this contribution merged on this project.

Please head over to https://ubuntu.com/legal/contributors to read more about it.

Copy link
Collaborator

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass. I have no opinion on naming.

// -*- Mode: Go; indent-tabs-mode: t -*-

/*
* Copyright (C) 2016-2017 Canonical Ltd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright is stale

c.Assert(spec.SecurityTags(), DeepEquals, []string{"snap.consumer.app"})
c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains,
`/dev/apusys rw`)
// c.Assert(spec.SnippetForTag("snap.consumer.app"), testutil.Contains,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left-over code?

@Asalle Asalle force-pushed the add-apusys-interface branch 2 times, most recently from 7077ec5 to 981941e Compare June 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants