daemon: fix data race when accessing requestedRestart #13987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was flagged by TIOBE as CID:NA-0e2ca076d1d5a16a07303509981ae85d Signed-off-by: Zygmunt Krynicki <[email protected]>
andrewphelpsj
approved these changes
May 21, 2024
github-actions
bot
added
the
Needs Documentation -auto-
zyga
removed
the
Needs Documentation -auto-
MiguelPires
approved these changes
May 21, 2024
bboozzoo
reviewed
May 22, 2024
| d.mu.Unlock() | ||
|
|
||
| // before not accepting any new client connections we need to write the | ||
| // maintenance.json file for potential clients to see after the daemon stops | ||
| // responding so they can read it correctly and handle the maintenance | ||
| if err := d.updateMaintenanceFile(d.requestedRestart); err != nil { | ||
| if err := d.updateMaintenanceFile(requestedRestart); err != nil { |
There was a problem hiding this comment.
as @MiguelPires pointed out there's one other place accessing d.requestRestart directly, and then one more accessing/modifying d.restartSocket
|
This needs some more work. I have alot bigger version but I didn't finish it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was flagged by TIOBE as CID:NA-0e2ca076d1d5a16a07303509981ae85d