tests/nested/manual: add multi-vol-gadget-updates spread test #11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reTo... Not including the unsupported volumes in the map entirely simplifies some logic in the full Update() change, so ensure that we only generate keys in the first level of the map for supported volumes. Signed-off-by: Ian Johnson <[email protected]>
…n UC20+ Finally switch over the implementation of Update() to use all of the preparatory functions and such that allow us to support multi-volume gadget asset updates on UC20. Remove unnecessary code in gadget/device_linux.go and update many tests. Signed-off-by: Ian Johnson <[email protected]>
Thanks to Alberto for the suggestion Signed-off-by: Ian Johnson <[email protected]>
…ates-FINAL-FOR-REAL-plz Signed-off-by: Ian Johnson <[email protected]>
Signed-off-by: Ian Johnson <[email protected]>
…omYaml Signed-off-by: Ian Johnson <[email protected]>
Also delete TODO since this is being handled correctly. Signed-off-by: Ian Johnson <[email protected]>
…volumes Previously we were enforcing that every volume needed to consume a kernel asset but really the condition is that only one volume across any of the volumes in a gadget consumes a kernel asset. Signed-off-by: Ian Johnson <[email protected]>
Signed-off-by: Ian Johnson <[email protected]>
…ng changed As requested by Samuele. Signed-off-by: Ian Johnson <[email protected]>
This is for multi-volume gadget asset update spread testing. Signed-off-by: Ian Johnson <[email protected]>
anonymouse64
added
⛔ Blocked
Test Robustness
Run nested
anonymouse64
changed the title
44 tasks
Add a spread test with several variants showing that we can perform multi-volume gadget asset updates. Signed-off-by: Ian Johnson <[email protected]>
anonymouse64
force-pushed
the
feature/uc20-multi-volume-gadget-asset-updates-spread-tests
branch
from
f968e7e
to
495940c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a spread test with several variants showing that we can perform
multi-volume gadget asset updates.
Note this particular spread test is broken due to ubuntu-image in Go, which is
not preparing filesystems that have content on other volumes properly.
The python version of ubuntu-image handled this properly however.
Based on top of #11494
This does not include a spread test for UC20 systems that were installed without support for multi-volume gadget asset updates that are then updated to a version of snapd that supports multi-volume updates and checks that the system-volume can be updated in this scenario. Ideally we would have that too since that's a scenario we want to support, though it is tested via unit tests extensively.