interfaces, o/ifacestate: don't allow devmode snaps calling other snaps on UC22 #11408
Conversation
…/behavior These unit tests were missing from the CVE branch, so proposing them now instead. Also fix a typo which we didn't have time to properly address while preparing the branch in private. Signed-off-by: Ian Johnson <[email protected]>
…ps on UC22 No customers can be depending on this behavior for UC22 since it isn't released yet so we can safely disable this unconditionally before anyone has a chance to depend on it. Signed-off-by: Ian Johnson <[email protected]>
anonymouse64
added
Simple 😃
Codecov Report
@@ Coverage Diff @@
## master #11408 +/- ##
==========================================
+ Coverage 78.34% 78.37% +0.02%
==========================================
Files 931 931
Lines 107005 107023 +18
==========================================
+ Hits 83838 83881 +43
+ Misses 17951 17924 -27
- Partials 5216 5218 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
| @@ -77,6 +78,8 @@ type Backend struct { | |||
|
|
|||
| coreSnap *snap.Info | |||
| snapdSnap *snap.Info | |||
|
|
|||
| model *asserts.Model | |||
There was a problem hiding this comment.
this is problematic because it will not be set during early first boot, it's not an issue for current usage but once it's there we might grow other usages and it will be confusing to keep in mind when it is set and when it is not. We need to discuss/find a different approach to have the relevant information available.
|
I will split off the other unit tests into a separate PR, I was probably too self-confident in thinking the model stuff would not be complex |
|
Other unit tests split out into #11409 |
|
@pedronis do we want to pursue this any further? |
yes, this and a related problem are on my/our tech debt list. Finding time/timing time is complicated though |
Eventually we will also disable this behavior of being able to call snap-confine from a devmode snap
for all other systems, but for now we can only get away with disabling UC22.
Also add missing unit tests from the branch we didn't have time to write/prepare.