internal/argon2: return errors #294
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already allow the memory cost to be set to a value that is greater than 4GiB - only capping the maximum here when benchmarking is used. This handles the threads parameter in the same way.
Passphrase support currently hardcodes the use of argon2i, which is the data-independent version of Argon2. Whilst this has better side-channel resistance than data-dependent versions, it requires more iterations to protect against time-memory tradeoff attacks. Cryptsetup recently switch to argon2id by default for passphrase hashing, which is the hybrid version that provides a good balance between side-channel resistance and time-memory tradeoff. This introduces support for selecting between the 2 versions for passphrase support. There are other versions of Argon2, such as the data-dependent version which sacrifices side-channel resistance for better resistance against time-memory tradeoff attacks, but this isn't supported by the argon2 go package.
This makes it clearer that we are actually testing something valid.
We're currently wrapping x/crypto/argon2 which panics on some invalid arguments. Instead, move the checking of these arguments in order to avoid some panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently wrapping x/crypto/argon2 which panics on some invalid
arguments. Instead, move the checking of these arguments in order to
avoid some panics.