Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase boot partition size to accommodate compression changes #88

Closed
wants to merge 14 commits into from

Conversation

jawn-smith
Copy link
Contributor

We had a discussion today about leaving space for organic growth of the initrd and the fact that changing compression sizes has led to larger initrd images.

@murraybd
Copy link

This looks good to me but is there somewhere (other than a t-shirt) we could put the formula used for calculating the size?

@jawn-smith
Copy link
Contributor Author

How about right here?

In [1]: fudge_factor = 2

In [2]: num_copies = 2

In [3]: kernel_size = 10

In [4]: initrd_size = 57

In [5]: other_boot_assets = 23

In [6]: boot_size = fudge_factor * (num_copies * ( kernel_size + initrd_size +other_boot_assets))

In [7]: boot_size
Out[7]: 360

Then rounding up to a nicer number we landed on 384. Some more detail:

flash-kernel always ensures there are two sets of boot assets, one with normal file paths and one with a .bak appended to each file path. This is the reason for the num_copies variable.

initrd_size and kernel_size are taken from kernel 5.15.0-1003-raspi

The "other boot assets" include things like start.elf, uboot, piboot, etc.

I have requested a review from waveform80 as I believe some of this might change in the future, like removing uboot altogether.

@jawn-smith
Copy link
Contributor Author

Dave and I had an offline conversation during which we decided to bump this to 512.

@waveform80
Copy link
Contributor

Is this now redundant with the classic-redesign branch?

@waveform80
Copy link
Contributor

Yup, this was resolved with classic-redesign getting merged; closing

@waveform80 waveform80 closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants