Updated for core22-desktop #103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenvandine
commented
Nov 10, 2023
kenvandine
commented
- Renamed snap to pi-desktop
- Increased size to accomodate seeded snaps
- Match default settings from the pc-desktop gadget
- Make necessary connections
* Renamed snap to pi-desktop * Increased size to accomodate seeded snaps * Match default settings from the pc-desktop gadget * Make necessary connections
| @@ -7,7 +7,7 @@ volumes: | |||
| role: system-seed | |||
| filesystem: vfat | |||
| type: 0C | |||
| size: 1200M | |||
| size: 3500M | |||
There was a problem hiding this comment.
If you plan to do things like a remodel from older gadget to this one, using min-size: 1200M would keep partitions compatible and make that possible.
There was a problem hiding this comment.
This gadget is published as pi-desktop, which is new. But in the future we may need to consider that if we ever need to grow beyond 3500M.
There was a problem hiding this comment.
It's entirely possible that we don't want a snap that's published under a different name in the source tree. The current pi-desktop snap is built/published from another repo under the canonical org. I'd like to hear what others think. Keeping it here in a branch will ease merging fixes/improvements from non-desktop branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.