Enhanced selected option detection to fix default title in IE8 #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caseyjhol
added a commit
that referenced
this pull request
May 31, 2015
Enhanced selected option detection to fix default title in IE8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the default title option doesn't work in IE8.
This plugin checks if there is a (pre)selected option available, and only shows the title as the first default option when that check fails.
This check works fine for most browsers, but in IE8 that check is always passed.
IE8 always returns
selectedfor the selected option, even if the markup doesn't have it. Other browsers returnnullin that case.jQuery's
attr()method is more advanced and returns the expected resultsSource