Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): create_dir_all doesn't error if path already exists #35

Merged
merged 3 commits into from
Apr 20, 2024
Merged

fix(docs): create_dir_all doesn't error if path already exists #35

merged 3 commits into from
Apr 20, 2024

Conversation

ThinkChaos
Copy link
Contributor

No description provided.

notgull
notgull requested changes Apr 20, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Run cargo fmt --all and I will merge this.

@ThinkChaos
Copy link
Contributor Author

Should be good!

Most functions are due for copying the std docs again BTW, but I just went the easy route ;)

notgull
notgull requested changes Apr 20, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On another look, it looks like this documentation is copied from create_dir as opposed to create_dir_all. Can you fix this?

src/lib.rs Outdated Show resolved Hide resolved
notgull
notgull approved these changes Apr 20, 2024
View reviewed changes
Copy link
Member

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/lib.rs Show resolved Hide resolved
@notgull notgull merged commit c058784 into smol-rs:master Apr 20, 2024
14 checks passed
@ThinkChaos ThinkChaos deleted the patch-1 branch April 20, 2024 20:23
@notgull notgull mentioned this pull request Apr 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notgull notgull notgull approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThinkChaos @notgull