Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation on Apple silicon #512

Merged

Conversation

flatmapthatshit
Copy link
Contributor

Builds are currently failing on M1 Mac due to Homebrew using a different path on M1 Macs (see Render96#47 for further details).
All credits for the fix goes to @halpz (original PR: Render96#48).

Additionally, while the Wiki often encourages parallel builds (e.g., with make -j4), tools/Makefile is not currently safe for parallel builds as it doesn't currently account for dependencies between programs.

E.g.:

  • tabledesign → audiofile
  • skyconv → n64graphics

More often than not, trying to compile tools with gmake OSX_BUILD=1 -j4 will fail due to tabledesign finishing to compile before audiofile and then failing to link.

While this would ideally be solved by introducing separate rules per program accounting for dependencies, for now I'm forcing j1 for tools.

@fgsfdsfgs
Copy link
Collaborator

Interesting. I can't test whether this breaks builds on other Macs since I don't have any, but it doesn't look like it should, so merging. Thanks. Pinging #452 in case anyone's watching that.

@fgsfdsfgs fgsfdsfgs merged commit afc7e8d into sm64pc:nightly Dec 19, 2022
@flatmapthatshit flatmapthatshit deleted the fix/compilation_on_apple_silicon branch December 20, 2022 00:05
Llennpie added a commit to Llennpie/Saturn that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants