Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS builds being broken #489

Merged
merged 8 commits into from
Nov 30, 2021
Merged

Fix macOS builds being broken #489

merged 8 commits into from
Nov 30, 2021

Conversation

Xenthio
Copy link
Contributor

@Xenthio Xenthio commented Nov 30, 2021 •
edited
Loading

checked on macOS 12 on Apple M1 Arm, should work on everything else too. (USING GCC 11)
fixes issues laid out in #83 and closes #462 and #447

@fgsfdsfgs
Copy link
Collaborator

fgsfdsfgs commented Nov 30, 2021 •
edited
Loading

Please see my comment in #83. Try applying -std=gnu99 for that particular tool. No need to enable -Wno-error=implicit-function-declaration.

@Xenthio
Copy link
Contributor Author

Xenthio commented Nov 30, 2021

Please see my comment in #83. Try applying -std=gnu99 for that particular tool. No need to enable -Wno-error=implicit-function-declaration.

pretty sure i checked and that was already there, lemme look again

@fgsfdsfgs
Copy link
Collaborator

Also to properly ignore all DS_Store files it should be enough to just add .DS_Store to gitignore.

@Xenthio
Copy link
Contributor Author

Xenthio commented Nov 30, 2021

Also to properly ignore all DS_Store files it should be enough to just add .DS_Store to gitignore.

pretty sure that only ignored them in the root dir, but I could be remembering incorrectly.

@fgsfdsfgs
Copy link
Collaborator

fgsfdsfgs commented Nov 30, 2021 •
edited
Loading

Nah, when you don't prefix it with a / it applies to the entire directory tree. Unless there's a / in the middle of the path already.

@fgsfdsfgs fgsfdsfgs merged commit fa49c7b into sm64pc:nightly Nov 30, 2021
@Xenthio
Copy link
Contributor Author

Xenthio commented Nov 30, 2021

this should also fix #462

This was referenced Nov 30, 2021
Closed
Open
AloXado320 added a commit to AloUltraExt/sm64ex-alo that referenced this pull request Dec 2, 2021
@AloXado320
sm64ex macOS build changes and more
27d5672 
Fix macOS builds being broken (sm64pc/sm64ex#489)

Makefile: more robust macOS build support + improvements to build speed (sm64pc/sm64ex#445)
GammaTendonNine added a commit to GammaTendonNine/sm64ex-alo that referenced this pull request May 25, 2022
@GammaTendonNine
aiff_extract_codebook.c: Remove implicit declaration of 'vsnprintf' e…
5b62d87 
…rroneously added in sm64pc/sm64ex#489

(merged via 27d5672)

[Proper fix within sm64pc/sm64ex would be to remove the '$define _XOPEN_SOURCE 500' which restricts the C standard to pre-C99
(see https://github.com/apple-oss-distributions/xnu/blob/e7776783b89a353188416a9a346c6cdb4928faad/bsd/sys/cdefs.h#L487)

This was done upstream in Refresh 14 in 0d67f95
(merged via f9982e0)]
AloXado320 pushed a commit to GammaTendonNine/sm64ex-alo that referenced this pull request May 23, 2023
@GammaTendonNine @AloXado320
aiff_extract_codebook.c: Remove implicit declaration of 'vsnprintf' e…
a0966ca 
…rroneously added in sm64pc/sm64ex#489

(merged via 27d5672)

[Proper fix within sm64pc/sm64ex would be to remove the '$define _XOPEN_SOURCE 500' which restricts the C standard to pre-C99
(see https://github.com/apple-oss-distributions/xnu/blob/e7776783b89a353188416a9a346c6cdb4928faad/bsd/sys/cdefs.h#L487)

This was done upstream in Refresh 14 in 0d67f95
(merged via f9982e0)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vsnprintf delcaration issue on Big Sur?
2 participants
@Xenthio @fgsfdsfgs