Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make source control recommended at L1 #164

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Make source control recommended at L1 #164

merged 2 commits into from
Sep 16, 2021

Conversation

TomHennen
Copy link
Contributor

Fixes #127

Once this is in we can tag 0.1.

inferno-chromium
inferno-chromium approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@inferno-chromium inferno-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also add

“○” = RECOMMENDED
in the text of that section so that people know meaning, i see you do this in other parts.

Thanks for making this change.

@TomHennen
Copy link
Contributor Author

Done

@inferno-chromium
Copy link
Contributor

Merging based on requirement satisfied as per this comment - #127 (comment)

@inferno-chromium inferno-chromium merged commit a25364a into slsa-framework:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLodato MarkLodato MarkLodato approved these changes

@inferno-chromium inferno-chromium inferno-chromium approved these changes

@joshuagl joshuagl Awaiting requested review from joshuagl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Version Control required for SLSA Level1
3 participants
@TomHennen @inferno-chromium @MarkLodato