Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add completion block to present function #94

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

jordanpichler
Copy link
Contributor

Summary

Add an optional completion block parameter to the present() function for code to be executed after presentation is completed. (just like the stock UIViewController.present())

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.

  • I've read and agree to the Code of Conduct.

  • I've written tests to cover the new code and functionality included in this PR.

@ste57 ste57 merged commit b2f5bd7 into slackhq:master Apr 21, 2020
@jordanpichler jordanpichler deleted the add-completion-block branch May 9, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants