Add allowTapToDismiss to PanModalPresentable #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ste57
reviewed
Oct 7, 2019
ste57
reviewed
Oct 7, 2019
ste57
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to add an additional point of configurability to the
PanModalPresentableprotocol. TheallowTapToDismissfunction will determine whether or not the presentable is dismissed when the dimmed background view is tapped.Similar to
allowDragToDismiss, this functionality can prevent the user from dismissing the presentable with an accidental tap. This is particularly important when they have unfinished work, or are in the middle of an important workflow.Requirements
I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've
writtenadded assertions to existing tests to cover the new code and functionality included in this PR.