Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Swift Package Manager #55

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

nikitskynikita
Copy link
Contributor

@nikitskynikita nikitskynikita commented Sep 26, 2019

Summary

IOS developers have a need to install a pan modal through SPM. Added the ability to connect a pan modal through SPM.

Requirements (place an x in each [ ])

@@ -5,6 +5,7 @@
// Copyright © 2019 Tiny Speck, Inc. All rights reserved.
//

#if os(iOS)
Copy link
Contributor

@TosinAF TosinAF Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heya! Thanks for working on this. QQ, Is is needed in all classes to limit it to iOS only? Not able to define in SPM that it's iOS only?

I'm not familiar with SPM yet, thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.
No, #if os(iOS) needed in only classes using specific iOS library such as UIKit. SPM allows to define target platform only for binary, but it doesn't include this property in build source. I found the article with solution for this problem, but I think that isn't good idea.

Copy link

@ciauri ciauri Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we now have Catalyst, this should be:
#if canImport(UIKit). I'm a little late! :(

Copy link

@DonBaronFactory DonBaronFactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@pedrommcarrasco
Copy link

Any update on this?

@minuscorp
Copy link

cc @nikitskynikita ❤️

@TosinAF TosinAF merged commit 45f8dfc into slackhq:master Nov 11, 2019
@TosinAF
Copy link
Contributor

TosinAF commented Nov 11, 2019

Just merged this change + updated for Swift 5.0.
Not as familiar with SPM yet so let me know if there are any issues still.
https://github.com/slackhq/PanModal/releases/tag/1.2.6

@TosinAF
Copy link
Contributor

TosinAF commented Nov 11, 2019

@nikitskynikita Thanks so much for your PR. That was a great help & apologies for the delay in merging.

@nikitskynikita nikitskynikita deleted the swift-package-manager branch November 13, 2019 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants