Support iOS 9 target #108
Open
Support iOS 9 target #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
it will be nice if we can get a clarification from the owner of the this Library, whether the support for ios 9 will be taken into the consideration or not. We also need to use this library as well need to support ios 9 in our App, so please give us some sign that we can able to use this library directly from the main repo. |
|
@ste57 Could you please review this PR, thanks |
|
Hi @omiddlk I'd recommend merging this on a fork as we're not looking to support iOS 9 publicly |
|
Hi @omiddlk will you be making a fork ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added Support for iOS 9 target (for projects that have min iOS 9 target and can't use PanModal)
Requirements (place an
xin each[ ])I've read and understood the Contributing Guidelines and have done my best effort to follow them.
I've read and agree to the Code of Conduct.
I've written tests to cover the new code and functionality included in this PR.