Skip to content
This repository has been archived by the owner on Aug 15, 2022. It is now read-only.

Fix to job_output bug #70

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Fix to job_output bug #70

merged 1 commit into from
Feb 5, 2018

Conversation

austin-taylor
Copy link
Contributor

@austin-taylor austin-taylor commented Jan 9, 2017

Resolves error where rtmbot crashes due to no job_output

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

e.g. New functionality for producing whatsits.

Related Issues

e.g. Fixes #206 and closes #230

Test strategy

e.g. Add tests around whatsit production.

Resolves error where rtmbot crashes due to no job_output
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 28.986% when pulling 1640620 on austin-taylor:patch-1 into d346225 on slackhq:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 28.986% when pulling 1640620 on austin-taylor:patch-1 into d346225 on slackhq:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 28.986% when pulling 1640620 on austin-taylor:patch-1 into d346225 on slackhq:master.

@Roach
Copy link
Contributor

Roach commented Feb 5, 2018

@austin-taylor would you mind signing the updated CLA so I can get this merged? :)

@austin-taylor
Copy link
Contributor Author

Done

@Roach Roach merged commit 6a13371 into slackapi:master Feb 5, 2018
@Roach Roach mentioned this pull request Feb 5, 2018
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants