socketmode remove duplicate debug logging #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smc.runRequestHandlerandsmc.runMessageReceiverare both run as goroutines.Respectively, when debug is enabled, they log the event:
smc.Debugf("Received WebSocket message: %s", message)smc.Debugln("Incoming WebSocket message:", reencoded)(in receiveMessagesInto)One of these should be removed. This PR removes the latter as it re-marshalls the json, and pretty prints (and was the offender that made me investigate this in the first place).
I'm open to other ideas too, as long as it means the end result is no pretty-printed log line, and no duplicate logging of the same data in full.