Remove Globals - Support ShadowDom for modern browsers and ShadyDOM polyfill for IE #2133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I'm wrapping quill with a webcomponent so it can be used with common diff/patch libraries (we are using Elm, but this should be possible with any diff/patch implementation). In order to make things work correctly with ShadowDOM, all of the global stuff needs to be refactored. This is what I attempted to do here.
Changes
getSelection()
see MDN docsnode.__quill
it assumes things that break ShadowDOM and the separation which is intended.How do we ge this published?
I'm not sure how to trigger all of the build/test stuff in this library or what processes y'all use to get a release published. If there is anything I can do to help with getting this published, please LMK.