Allow setting the workdir using environment variables #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thanks @BabyChouSr! I tested manually and it works. Can we add some tests for this functionality?
Yup! just added a simple one in |
There was a problem hiding this comment.
Thanks @BabyChouSr! This should be good to go after the linter passes.
| @@ -146,3 +146,13 @@ def test_invalid_empty_envs(tmp_path): | |||
| with pytest.raises(ValueError) as e: | |||
| Task.from_yaml(config_path) | |||
| assert 'Environment variable \'env_key2\' is None.' in e.value.args[0] | |||
|
|
|||
There was a problem hiding this comment.
You may want to run ./format.sh (after running pip install -r requirements-dev.txt) to keep the linter happy.
Suggested change
romilbhardwaj
approved these changes
Jul 28, 2024
Co-authored-by: Romil Bhardwaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the workdir to be configured using environment variables.
Closes #3271
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_nameconda deactivate; bash -i tests/backward_compatibility_tests.sh