Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Task level config #3689

Merged
merged 24 commits into from
Jul 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix test
  • Loading branch information
Michaelvll committed Jul 8, 2024
commit ebd9586f95ce3a84c412fc6be28a1b338da0efb6
5 changes: 3 additions & 2 deletions sky/provision/kubernetes/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -1433,10 +1433,11 @@ def combine_pod_config_fields(
with open(cluster_yaml_path, 'r', encoding='utf-8') as f:
yaml_content = f.read()
yaml_obj = yaml.safe_load(yaml_content)
# We don't use override_config in `skypilot_config.get_nested`, as merging
# We don't use override_configs in `skypilot_config.get_nested`, as merging
# the pod config requires special handling.
kubernetes_config = skypilot_config.get_nested(('kubernetes', 'pod_config'),
default_value={})
default_value={},
override_configs={})
override_pod_config = (cluster_config_overrides.get('kubernetes', {}).get(
'pod_config', {}))
merge_dicts(override_pod_config, kubernetes_config)
Expand Down
Loading