[Cudo] Update and bugfixes #3256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Mar 7, 2024
There was a problem hiding this comment.
Thank you for updating the Cudo support @JungleCatSW! Left two comments :)
Michaelvll
reviewed
Apr 25, 2024
# Conflicts: # sky/provision/cudo/cudo_wrapper.py
Michaelvll
reviewed
May 24, 2024
There was a problem hiding this comment.
Thanks for the change @JungleCatSW! Left a comment for a potential remnant. : )
Michaelvll
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thanks for the fix @JungleCatSW! It works for me. Merging.
Note: not sure why it happens, but during launching a V100 machine on Cudo compute, skypilot fails to pip install ray[default]==2.9.3 as its dependency as it takes forever to download the package.
|
Just tested it with |
Michaelvll
pushed a commit
that referenced
this pull request
Aug 23, 2024
* bug fixes and improvements * moved shared function to helper, added error message * moved catalog helper to utils * small fixes * fetch cudo fix * id fix for vms.csv file * format fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides checks to prevent VMs hanging on pending, and updates base images for VM with newer Cuda version.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh