[Serve] Rolling update #3249
Merged
[Serve] Rolling update #3249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaoZiming
reviewed
Feb 29, 2024
|
Tested (9f60154)
|
MaoZiming
reviewed
Mar 14, 2024
MaoZiming
reviewed
Mar 14, 2024
MaoZiming
reviewed
Mar 14, 2024
MaoZiming
reviewed
Mar 14, 2024
| ready. Traffic can be mixed on old and new replicas. | ||
| - "blue_green": SkyServe will update the service with blue-green update, | ||
| i.e., it will wait for new replicas to be ready and then terminate old | ||
| replicas. Traffic will only be switched from old to new replicas after |
There was a problem hiding this comment.
Suggested change
| replicas. Traffic will only be switched from old to new replicas after | |
| replicas. Traffic will only be served from old to new replicas after |
There was a problem hiding this comment.
It might be more clear with switched since it means we change from the old to new replicas only after the number of replicas is enough.
MaoZiming
reviewed
Mar 14, 2024
MaoZiming
reviewed
Mar 14, 2024
sky/serve/replica_managers.py
Outdated
| @@ -513,6 +530,7 @@ def __init__(self, service_name: str, | |||
| self._next_replica_id: int = 1 | |||
| self._service_name: str = service_name | |||
| self._uptime: Optional[float] = None | |||
| self._update_mode = serve_utils.UpdateMode.ROLLING | |||
There was a problem hiding this comment.
shall we make this as a constant DEFAULT_UPDATE_MODE?
MaoZiming
reviewed
Mar 14, 2024
MaoZiming
reviewed
Mar 14, 2024
MaoZiming
approved these changes
Mar 14, 2024
Co-authored-by: Ziming Mao <[email protected]>
Co-authored-by: Ziming Mao <[email protected]>
Co-authored-by: Ziming Mao <[email protected]>
Co-authored-by: Ziming Mao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the default behavior to rolling update, and we allow the user to specify the update mode to
blue_green, which is the same as the current master branch.Some reference for the two way of update: https://blog.itaysk.com/2017/11/20/deployment-strategies-defined
This also shows the current active version in
sky serve statusBlocked by #3299
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.py --servepytest tests/test_smoke.py --managed-spotpytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh