-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UX] Support checking user specified cloud(s) with sky check
from CLI
#3229
[UX] Support checking user specified cloud(s) with sky check
from CLI
#3229
Conversation
Requesting review @Michaelvll @romilbhardwaj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dtran24! This is great, personally this feature will save me a lot of time :)
This is very useful and we should get it in soon! |
PTAL when you have the chance! @romilbhardwaj |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dtran24! Tested it and works nicely! Left some comments on the code.
…o ux/sky-check-select # Conflicts: # sky/check.py # sky/cli.py
sky/check.py
Outdated
|
||
def check_one_cloud(cloud_tuple: Tuple[str, clouds.Cloud]) -> None: | ||
def check_one_cloud(cloud_tuple: Tuple[str, Any]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note - Any
was required for cloudflare support, which is not a cloud but a module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about Union[sky_clouds.Cloud, ModuleType]
? (from types import ModuleType
)
Ready for review @cblmemo! Tested with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this @romilbhardwaj ! The PR looks great to me except for several its. It should be ready to go after fixing those!
sky/check.py
Outdated
|
||
def check_one_cloud(cloud_tuple: Tuple[str, clouds.Cloud]) -> None: | ||
def check_one_cloud(cloud_tuple: Tuple[str, Any]) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about Union[sky_clouds.Cloud, ModuleType]
? (from types import ModuleType
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! LGTM :))
Thanks for the reviews @cblmemo! Merging now. |
Nice work! Thanks David & Romil.
We may want to show a quick usage example in (1) CLI help str, (2) docs?
…On Wed, May 15, 2024 at 11:29 PM Romil Bhardwaj ***@***.***> wrote:
Merged #3229 <#3229> into
master.
—
Reply to this email directly, view it on GitHub
<#3229 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEQWHSGSCD4CF6CZXINQTDZCRG6BAVCNFSM6AAAAABDZGL34CVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHAZDONRYHE4TOMA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Fixes #3131
Tested (run the relevant ones):
bash format.sh
sky check
. Tests no cloud being specified. All clouds checked as expectedsky check aws
. Tests checking single enabled cloudsky check aws gcp
. Tests checking mix of multiple enabled cloudssky check aws gcp oci
. Tests checking mix of enabled and disabled cloudssky check gcp oci aws
. Tests alphabeticalsky check aws gcp oci fluidstack
sky check aws gcp oci Test
. Tests invalid cloud. As expected, raises errorpytest tests/test_smoke.py
pytest tests/test_smoke.py::test_fill_in_the_name
bash tests/backward_comaptibility_tests.sh