Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SkyServe] Ngrok Ingress #2862

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

[SkyServe] Ngrok Ingress #2862

wants to merge 3 commits into from

Conversation

cblmemo
Copy link
Collaborator

@cblmemo cblmemo commented Dec 13, 2023

image

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

Copy link

This PR is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label May 24, 2024
Copy link

github-actions bot commented Jun 3, 2024

This PR was closed because it has been stalled for 10 days with no activity.

@github-actions github-actions bot closed this Jun 3, 2024
@Michaelvll
Copy link
Collaborator

Is this still relevant considering we have changed the redirection to proxy @cblmemo?

@cblmemo
Copy link
Collaborator Author

cblmemo commented Jun 3, 2024

Is this still relevant considering we have changed the redirection to proxy @cblmemo?

Good point! Reopened.

@cblmemo cblmemo reopened this Jun 3, 2024
@github-actions github-actions bot removed the Stale label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants