Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[show-gpus] Change pandas groupby function to str instead of callable #2583

Merged
merged 1 commit into from
Sep 19, 2023
Merged

[show-gpus] Change pandas groupby function to str instead of callable #2583

merged 1 commit into from
Sep 19, 2023

Conversation

romilbhardwaj
Copy link
Collaborator

@romilbhardwaj romilbhardwaj commented Sep 19, 2023 •
edited
Loading

Closes #2582.

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • pytest tests/test_list_accelerators.py
  • Manual tests - run sky show-gpus
    • Tested with pandas 2.1.0
    • Tested with pandas 2.0.3
    • Tested with pandas 1.3.0 (the oldest version supported by SkyPilot master)
    • Manually checked pricing against output of sky show-gpus -a on master.

@romilbhardwaj
Copy link
Collaborator Author

Thanks @Michaelvll! Tested with pandas 1.3.0, seems to work fine. Will go ahead and merge this.

@romilbhardwaj romilbhardwaj merged commit ec78242 into master Sep 19, 2023
18 checks passed
@romilbhardwaj romilbhardwaj deleted the pandas_agg_upd branch September 19, 2023 16:07
romilbhardwaj added a commit that referenced this pull request Sep 19, 2023
@romilbhardwaj
[show-gpus] Change pandas groupby function to str instead of callable (…
c324612 
…#2583)

pandas call update

(cherry picked from commit ec78242)
@romilbhardwaj romilbhardwaj mentioned this pull request Oct 25, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michaelvll Michaelvll Michaelvll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[show-gpus] pandas FutureWarning on running sky show-gpus
2 participants
@romilbhardwaj @Michaelvll