Minor: print more detailed Lambda errors. #2371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cblmemo
reviewed
Aug 9, 2023
| @@ -86,8 +87,10 @@ def raise_lambda_error(response: requests.Response) -> None: | |||
| resp_json = response.json() | |||
| code = resp_json.get('error', {}).get('code') | |||
| message = resp_json.get('error', {}).get('message') | |||
| except (KeyError, json.decoder.JSONDecodeError): | |||
There was a problem hiding this comment.
Why are we removing the KeyError here?
There was a problem hiding this comment.
dict.get() doesn't throw KeyError?
| except json.decoder.JSONDecodeError: | ||
| raise LambdaCloudError('Unexpected error. Status ' | ||
| f'code: {status_code}; response: {response}; ' | ||
| f'resp_json: {resp_json}') |
There was a problem hiding this comment.
Shall we add response.reason or response.text to indicate which error happened? Since repr of requests.Response is something like <Response [404]> and does not contain a lot of useful information.
Also, why are we printing resp_json in except json.decoder.JSONDecodeError ? IIUC the resp_json must be None?
There was a problem hiding this comment.
Good catch, done.
cblmemo
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have reported seeing this exception being triggered without much info.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh