Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fix status refresh when manually restarted #2203

Merged
merged 3 commits into from
Jul 10, 2023
Merged

[Core] Fix status refresh when manually restarted #2203

merged 3 commits into from
Jul 10, 2023

Conversation

Michaelvll
Copy link
Collaborator

@Michaelvll Michaelvll commented Jul 9, 2023 •
edited

Fixes #2202

Tested (run the relevant ones):

  • Code formatting: bash format.sh
  • Any manual or new tests for this PR (please specify below)
    • reproducible code in the issue
  • All smoke tests: pytest tests/test_smoke.py
  • Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
  • Backward compatibility tests: bash tests/backward_comaptibility_tests.sh

@Michaelvll Michaelvll marked this pull request as ready for review July 9, 2023 19:25
concretevitamin
concretevitamin approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@concretevitamin concretevitamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Michaelvll, LGTM.

sky/global_user_state.py Outdated Show resolved Hide resolved
@Michaelvll Michaelvll merged commit 1e3537c into master Jul 10, 2023
15 checks passed
@Michaelvll Michaelvll deleted the fix-status-refresh-when-start branch July 10, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@concretevitamin concretevitamin concretevitamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[core] sky status -r fails when a stopped cluster is manually started
2 participants
@Michaelvll @concretevitamin