one byte fixing a5000 and a6000 on-prem #2023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on prem machines with a6000 or a5000 didn't work correctly because of a missing comma in the array the grep was for
lspci | grep 'A5000A6000'
which... isn't a card anyone has.I think it may make sense to have a look at this script, it feels quite fragile. Probably best would be to do this via
nvidia-smi -L
and just map against the ./.sky/catalog to find supported gpus.Also, the way this made things fail was rather frustrating.
sky status showed (no GPUs) and sky launch fails predictably with
AssertionError: (Local(None), 'cloud, region and instance_type must have been set by optimizer')
sky launch -c local totally misreported the error as
I think it's a good idea to detect this failure and report that (remote) ~/.sky/get_resources.py couldn't detect any GPUs or some such thing.