Make sky status -r updates the owner of the cluster #1809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
concretevitamin
approved these changes
Mar 24, 2023
| @@ -1770,6 +1770,7 @@ def check_owner_identity(cluster_name: str) -> None: | |||
| 'allow the operation as the two identities are likely to have ' | |||
| 'the same access to the cluster, but please be aware that ' | |||
| 'this is not guaranteed.') | |||
| if i != 0 or len(owner_identity) != len(current_user_identity): | |||
There was a problem hiding this comment.
Add a comment on why these conditions?
also “this is not guaranteed “ seems vague; rephrase possible?
There was a problem hiding this comment.
Good point! Added. PTAL. : )
concretevitamin
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow
sky status -rupdate the owner of the cluster, so that the user can be easier to migrate the existing cluster to the new identity setting.Tested (run the relevant ones):
pytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh