Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

b-spline lib fails on floating point error #28

Closed
bjnortier opened this issue Jul 12, 2018 · 4 comments
Closed

b-spline lib fails on floating point error #28

bjnortier opened this issue Jul 12, 2018 · 4 comments
Assignees
Labels

Comments

@bjnortier
Copy link
Collaborator

The b-spline lib domain check can fail due to a floating point error - either the lib must be updated or the error caught and handled.

@bjnortier
Copy link
Collaborator Author

Pull request submitted to b-spline: thibauts/b-spline#13

@davidgilbertson
Copy link

davidgilbertson commented Jan 16, 2019

Ah I just logged a bug with b-spline before finding this: thibauts/b-spline#14

It looks like b-spline is dead, would you consider forking it or removing the dependency? This bug is blocking us from importing some DXFs.

Edit: scratch that, I just was that you've wrapped the call to b-spline in a try/catch and I didn't have the latest version.

Nice work!

@bjnortier
Copy link
Collaborator Author

Thanks!

I'll do a bit of maintenance today and will probably just incorporate the algorithm into dxf since this library is inactive

@bjnortier
Copy link
Collaborator Author

Published 3.4.0 which incorporates b-spline into the lib and removes the b-spline dependency

bjnortier added a commit that referenced this issue Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants