Fix bug in tag prefix trimming #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me @alangibson01 . In order to get the release working you will need to prefix your commit with |
The tag prefix trimming was using `strings.TrimLeft`, which gave an incorrect result if the tag prefix happened to contain a digit that was also in the version number. For example: `myapp1-1.0.0` would be trimmed to `.0.0` rather than `1.0.0`. The correct function to use in this case is `strings.TrimPrefix`.
011d743
to
13c65b9
Compare
|
@chuckydev Amended. Thanks for spotting that! |
chuckydev
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tag prefix trimming was using
strings.TrimLeft, which gave an incorrect result if the tag prefix happened to contain a digit that was also in the version number.For example:
myapp1-1.0.0would be trimmed to.0.0rather than1.0.0.The correct function to use in this case is
strings.TrimPrefix.Fixes #9