Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forecast works on 0.1.8 level but breaks at the 0.2.1 level #210

Open
GREENENVIRON123 opened this issue Oct 26, 2023 · 2 comments
Open

Forecast works on 0.1.8 level but breaks at the 0.2.1 level #210

GREENENVIRON123 opened this issue Oct 26, 2023 · 2 comments

Comments

@GREENENVIRON123
Copy link

Issue: With the included Storage_Utilization.csv series daily data points I ran the below forecast. This works fine at the 0.1.8 level but at the 0.2.1 level the forecast skips the week 1 of Actual data and starts the forecast at week 2., thereby producing a forecast that is 7 days short.

Observations:
(1) A "snaive_wday" is chosen as the model
(2) The input data ideally should have included the whole month of October 2023 but is missing the last week of October. At the 0.1.8. level this worked fine.

#See Attached files here:

#Input Series
Storage_Utilization.csv

#Resulting Forecast
Forecasted_DF.csv

                   #CODE Follows:

                   #Convert  Storage_Utilization.csv to Pandas Dataframe, name it pdf and ingest
                   #Forecast / extrapolate_years "fut" variable resolves to 182 days

                    get_forecast  =  forecast.run_forecast(pdf, extrapolate_years=fut, simplify_output=True, include_all_fits=False,      \
                                   find_outliers=False, l_model_trend = [forecast_models.model_linear, forecast_models.model_constant,  \
                                   forecast_models.model_exp, forecast_models.model_step, forecast_models.model_quasilinear],             \
                                   l_model_season = [forecast_models.model_null])

                    antlgh = len(get_forecast)
                    print("Forecast DF Length: " + str(antlgh))

                    #Output Forecasted_DF.csv for debugging
                    fct       = specify.output_path +  "Forecasted_DF" +  ".csv"
                    get_forecast.to_csv(fct, index=False)
@capelastegui
Copy link
Contributor

I think that's just how the snaive_wday model works - it copies the weekly samples from the previous week, so it has nothing for week 1. The model behaviour has not changed between 0.1.8 and 0.2.1, but model selection has - you probably were getting a plain naive model with the previous version. You can disable naive models altogether by passing l_model_naive=[], and see how non-naive models perform in that scenario (probably not great). If you see other models missing samples like this, then that is a bug that we need to address.

@GREENENVIRON123
Copy link
Author

GREENENVIRON123 commented Oct 27, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants