Implement a provider model for RDS/Stdout mysql providers. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
nickschuch
reviewed
Jun 26, 2024
nickschuch
reviewed
Jun 26, 2024
nickschuch
reviewed
Jun 26, 2024
nickschuch
reviewed
Jun 26, 2024
nickschuch
reviewed
Jun 26, 2024
nickschuch
reviewed
Jun 26, 2024
nickschuch
reviewed
Jun 26, 2024
|
Love the approach. I have left a review for next steps. Can we also get a functional test for atleast the |
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
Signed-off-by: Karl Hepworth <[email protected]>
|
Here's the functional test - all green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off the work done in #28, this segments the execution flow in a more coherent way using the 'provider model' to split out common functionality between the two routes of execution.
It keeps a single input for the user, where the user can provide a route of path, or use the default which is the current implementation on the main branch.