eliminate the result accumulator setup outside the reduce #3
+3
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if I like the change now I've done it. However I was motivated to eliminate the setup outside the reduce.
I kind of like the symmetry of having that array passed in to the reduce, that has a slowly building first part (roman numeral) and a slowly diminishing second part (number to be converted -> remainder).
I like the fewer lines.
I dislike that it's less readable.