Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eliminate the result accumulator setup outside the reduce #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baob
Copy link

@baob baob commented Jun 2, 2016

I'm not sure if I like the change now I've done it. However I was motivated to eliminate the setup outside the reduce.

I kind of like the symmetry of having that array passed in to the reduce, that has a slowly building first part (roman numeral) and a slowly diminishing second part (number to be converted -> remainder).

I like the fewer lines.

I dislike that it's less readable.

@baob
Copy link
Author

baob commented Jun 3, 2016

Great article, BTW. Set me thinking, as usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant