Increase timeout for aws client timeout and retry errors not captured… (

open-telemetry#8735)
siyuniu-ms · Jun 15, 2023 · 7719a91 · 7719a91
1 parent 6a8cce2
commit 7719a91
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/...tion/aws-sdk/aws-sdk-1.11/javaagent/src/test_before_1_11_106/groovy/Aws0ClientTest.groovy b/...tion/aws-sdk/aws-sdk-1.11/javaagent/src/test_before_1_11_106/groovy/Aws0ClientTest.groovy
@@ -234,8 +234,8 @@ class Aws0ClientTest extends AgentInstrumentationSpecification {
  def "timeout and retry errors not captured"() {
  setup:
  // One retry so two requests.
- server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(500)))
- server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(500)))
+ server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(5000)))
+ server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(5000)))
  AmazonS3Client client = new AmazonS3Client(new ClientConfiguration()
  .withRequestTimeout(50 /* ms */)
  .withRetryPolicy(PredefinedRetryPolicies.getDefaultRetryPolicyWithCustomMaxRetries(1)))

diff --git a/...rc/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.groovy b/...rc/main/groovy/io/opentelemetry/instrumentation/awssdk/v2_2/AbstractAws2ClientTest.groovy
@@ -506,8 +506,8 @@ abstract class AbstractAws2ClientTest extends InstrumentationSpecification {
  def "timeout and retry errors not captured"() {
  setup:
  // One retry so two requests.
- server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(500)))
- server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(500)))
+ server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(5000)))
+ server.enqueue(HttpResponse.delayed(HttpResponse.of(HttpStatus.OK), Duration.ofMillis(5000)))
  def client = S3Client.builder()
  .overrideConfiguration(createOverrideConfigurationBuilder()
  .retryPolicy(RetryPolicy.builder().numRetries(1).build())