Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: baudrate bug #22

Merged
merged 2 commits into from
Mar 21, 2023
Merged

hotfix: baudrate bug #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8ca56c
fix: Bug while specifiying baudrate paramater
selengalp Mar 21, 2023
3760fb6
Update version 0.4.2
selengalp Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion atcom/__version__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
VERSION = (0, 4, 1)
VERSION = (0, 4, 2)

__version__ = '.'.join(map(str, VERSION))
8 changes: 6 additions & 2 deletions atcom/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def get_response(self, timeout):
timer = millis()

while True:
delay(100)
delay(2)
if millis() - timer < timeout:
while self.serial.inWaiting():
try:
Expand Down Expand Up @@ -163,6 +163,7 @@ def handler(port, baudrate, timeout, verbose, rts_cts, dsr_dtr, config, at_comma

properties = (
{"id": "port", "name": "Port", "required": True},
{"id": "baudrate", "name": "Baudrate", "required": False},
{"id": "rts_cts", "name": "RTS-CTS", "required": False},
{"id": "dsr_dtr", "name": "DSR_DTR", "required": False},
{"id": "timeout", "name": "Timeout", "required": False}
Expand All @@ -173,7 +174,10 @@ def handler(port, baudrate, timeout, verbose, rts_cts, dsr_dtr, config, at_comma
if not locals().get(_property["id"], None):
continue

logger.info("{} property specified as argument, overriding config file".format(_property["name"]))
logger.info("{} property specified as argument, overriding config file: {}"
.format(_property["name"], locals().get(_property["id"]))
)

configs[_property["id"]] = locals().get(_property["id"])

if not configs.get("port"):
Expand Down