Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/swn 38 #34

Merged
merged 21 commits into from
Feb 15, 2024
Merged

Features/swn 38 #34

merged 21 commits into from
Feb 15, 2024

Conversation

liz-arikawa-esa
Copy link
Contributor

No description provided.

bootstrap 4 -> 5
update the prestart in package.json
* Configuring Linting for the project
* Adjusting Dockerfile to use npm ci
* committing the package-lock.json file
Update rte toolbars
# Conflicts Resolved:
#	Nebula.Web/src/app/pages/field-definition-edit/field-definition-edit.component.html
#	Nebula.Web/src/app/pages/field-definition-edit/field-definition-edit.component.ts
#	Nebula.Web/src/app/shared/components/field-definition/field-definition.component.html
#	Nebula.Web/src/app/shared/components/field-definition/field-definition.component.ts
#	Nebula.Web/src/app/shared/components/header-nav/header-nav.component.html
#	Nebula.Web/src/app/shared/helpers/tiny-mce-helpers.ts
Copy link
Contributor

@stewartgordonsitka stewartgordonsitka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Liz, I know this was probably supposed to be a quick story. But since you're working on some tinymce component usages I think we should take the time to add the pipe from KAP over to this project and utilize it on all of the <editor> components.

Let me know if you have any questions!

Copy link
Contributor

@stewartgordonsitka stewartgordonsitka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stewartgordonsitka stewartgordonsitka merged commit bca6853 into develop Feb 15, 2024
@stewartgordonsitka stewartgordonsitka deleted the features/SWN-38 branch February 15, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants