Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor overlap functions and add new test envs #111

Merged
merged 6 commits into from
Jan 21, 2024

Conversation

diegodoimo
Copy link
Collaborator

  1. I removed wrong and redundant return_overlap coord. Now compute_data_overlap must be used;
  2. removed also the reduntant 'return_label_overlap_coords' 'return_label_overap_selected_coord'. Now return label overlap should be used.
  3. added new test environments (python 10, 11, 12) in .yml files

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (432568f) 80.28% compared to head (1970ef8) 79.13%.

Files Patch % Lines
dadapy/metric_comparisons.py 43.75% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
- Coverage   80.28%   79.13%   -1.16%     
==========================================
  Files          15       15              
  Lines        2496     2506      +10     
==========================================
- Hits         2004     1983      -21     
- Misses        492      523      +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@diegodoimo diegodoimo merged commit f1d07a2 into main Jan 21, 2024
8 checks passed
@diegodoimo diegodoimo deleted the remove_wrong_overlap_funcs_update_test_envs branch February 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants