Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staged changes for final project in forked repo #43

Merged
merged 2 commits into from
Dec 18, 2016

Conversation

gregramel
Copy link
Contributor

Greg Ramel (gramel) final project - Conditional Independence and Greedy Thick-Thinning

@coveralls
Copy link

coveralls commented Dec 11, 2016

Coverage Status

Coverage decreased (-4.4%) to 90.226% when pulling 34237fa on gregramel:master into 7bb0c94 on sisl:master.

@mykelk
Copy link
Member

mykelk commented Dec 11, 2016

This looks pretty good. It looks like it only includes an independence test but no greedy thick thinning, right? Can something be added to the Jupyter notebook documentation?

Copy link
Contributor

@tawheeler tawheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Could you change is_independent to take AbstractVectors?
Could LightGraphs.jl be used to find descendants? Make run collect on a DFS or BFS traversal?

@tawheeler tawheeler mentioned this pull request Dec 14, 2016
8 tasks
@tawheeler
Copy link
Contributor

I will merge this and make the changes.

@tawheeler tawheeler merged commit 2877304 into sisl:master Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants