Fix for #121 #130

dwijenchawra · 2021-05-11T07:25:40Z

Resolved #121, rewrote deprecated DataFrame conversions

coveralls · 2021-05-11T07:34:52Z

Coverage increased (+0.9%) to 86.403% when pulling dc240d6 on dwijenchawra:master into b700d78 on sisl:master.

mykelk

Just minor things. Let's see if we can continue supporting the older version of DataFrames. If not, then we can drop support for the older versions.

Project.toml

src/DiscreteBayesNet/discrete_bayes_net.jl

src/DiscreteBayesNet/structure_scoring.jl

src/sampling.jl

src/Factors/factors_dataframes.jl

Project.toml

dwijenchawra and others added 8 commits May 10, 2021 20:09

fixed matrix conversion

d2b14de

added auto parameter

ae67c78

fixed dataframe conversion

d2e62c0

updated dataframe reqs

430ffa8

fixed sampling bug

150f28e

refactored all instances of convert

5ff9f3d

Merge remote-tracking branch 'origin/master'

3bfbd62

Merge branch 'sisl:master' into master

a7eee35

dwijenchawra requested a review from tawheeler May 11, 2021 07:25

mykelk requested changes May 11, 2021

View reviewed changes

dwijenchawra added 3 commits May 11, 2021 13:58

updated Dataframes versions

b70892c

Merge remote-tracking branch 'origin/master'

4526c6c

removed commented lines

c685abb

dwijenchawra commented May 13, 2021

View reviewed changes

src/Factors/factors_dataframes.jl Show resolved Hide resolved

mykelk reviewed May 13, 2021

View reviewed changes

Project.toml Outdated Show resolved Hide resolved

mykelk removed the request for review from tawheeler May 13, 2021 15:37

changed Dataframes version again

dc240d6

mykelk approved these changes May 13, 2021

View reviewed changes

mykelk merged commit bae05ed into sisl:master May 13, 2021

Provide feedback