Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia Version Compatibility #84

Closed
mehalter opened this issue Sep 5, 2019 · 7 comments
Closed

Julia Version Compatibility #84

mehalter opened this issue Sep 5, 2019 · 7 comments
Assignees

Comments

@mehalter
Copy link

mehalter commented Sep 5, 2019

The current Project.toml has an error that says that it supports julia >= 0.7. This is incorrect. Could you please update it in different versions to reflect to actually supported versions? Version 3.0.0 for example works on Julia v1.0, but 3.1.0 only works on Julia 1.1.

This compatibility error in the Project.toml causes the registry for Julia 1.0 to pull the wrong version and BayesNets doesn't actually work anymore on Julia 1.0.

@mossr
Copy link
Member

mossr commented Sep 5, 2019

@tawheeler is this as simple as updating the Project.toml to require Julia >= 1.1.0 or should we tag a new BayesNets.jl version in the process?

@mykelk
Copy link
Member

mykelk commented Sep 5, 2019

Yeah, you'll need to update it along with increment the version number in a commit. Then you will want to add a comment like this to trigger JuliaRegistrator. Then the JuliaTagBot will automatically tag a release once it is merged into the registry.

@mossr
Copy link
Member

mossr commented Sep 5, 2019

@mykelk want me to submit a pull request for this, or continue on master?

@mossr
Copy link
Member

mossr commented Sep 5, 2019

@mykelk disregard that, I'm going down the pull request route.

@mykelk
Copy link
Member

mykelk commented Sep 5, 2019

@mossr either way is fine with me.

mossr added a commit that referenced this issue Sep 5, 2019
Updated version to v3.2.0, requiring Julia >= 1.1 (#84)
@mehalter
Copy link
Author

mehalter commented Sep 6, 2019

I would recommend you also tag a version that supports 1.0 and had the correct compatibility line so that the package has a version that supports the LTS version of Julia.

@mossr
Copy link
Member

mossr commented Sep 10, 2019

@mehalter BayesNets v3.1.0 works on Julia v1.0 for me. You mentioned v3.1.0 only works on Julia v1.1—what were you seeing that suggested that?

@mykelk mykelk closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants