Move airbrake #261
Merged
Move airbrake #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2015 14:28
The current implementation is using an old implementation of the Airbrake v2 api. Airbrake has release v2 since, but this package is necessary for in-house solutions like errbit. The number of errbit users don't justify to continue pushing this version as the official. That's why the official hook is now using gobrake (the official package), and the one coming from logrus is now named "legacy".
|
Thank you so much for your work @gravis. |
|
That was quick :) |
|
forgot to update the changelog :( |
|
Ya, I did that in master :) Logrus will abuse the pre 1.0 tag until we settle on an API. For 1.0 for example I plan to have hooks and formatters use the same API. This work is in preparation for 1.0 and to cut down on maintenance burden. |
devopstaku
pushed a commit
to devopstaku/logrus
that referenced
this pull request
Aug 9, 2016
Move airbrake
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is using an old implementation of the
Airbrake v2 api. Airbrake has release v2 since, but this package is
necessary for in-house solutions like errbit.
The number of errbit users don't justify to continue pushing this
version as the official.
That's why the official hook is now using gobrake (the official
package), and the one coming from logrus is now named "legacy".
Note that I suggest to remove completely the examples folder , which is redundant with all the examples in the README