Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextMarshaler and TextUnmarshaler implementation for Level #254

Merged
merged 1 commit into from
Oct 5, 2015
Merged

TextMarshaler and TextUnmarshaler implementation for Level #254

merged 1 commit into from
Oct 5, 2015

Conversation

digitalcrab
Copy link
Contributor

Hello guys

Please accept my pull request. This can be useful from thoes who loads log level from some config files (yaml, json or wherever).

Thank you

@sirupsen
Copy link
Owner

sirupsen commented Oct 5, 2015

Hi, this use-case has not come up enough to make it into core. Since this uses the PublicApi, you can use your own helper. Thank you!

sirupsen added a commit that referenced this pull request Oct 5, 2015
TextMarshaler and TextUnmarshaler implementation for Level
@sirupsen sirupsen merged commit 5a15866 into sirupsen:master Oct 5, 2015
@sirupsen
Copy link
Owner

sirupsen commented Oct 5, 2015

Accidentally merged (now reverted) when I meant to close, sorry.

devopstaku pushed a commit to devopstaku/logrus that referenced this pull request Aug 9, 2016
TextMarshaler and TextUnmarshaler implementation for Level
cgxxv pushed a commit to cgxxv/logrus that referenced this pull request Mar 25, 2022
TextMarshaler and TextUnmarshaler implementation for Level
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants