Skip to content
This repository has been archived by the owner on Jun 28, 2024. It is now read-only.

Commit

Permalink
Merge pull request #828 from sirensolutions/kibi-issue-6
Browse files Browse the repository at this point in the history
introduced kibi_version variable
  • Loading branch information
szydan committed Mar 11, 2016
2 parents 9b0b16f + ad71ae4 commit da02cd1
Show file tree
Hide file tree
Showing 11 changed files with 18 additions and 7 deletions.
5 changes: 4 additions & 1 deletion modified_kibana_files.txt
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ src/plugins/kibana/public/kibana.js

src/plugins/kibana/public/settings/app.html
src/plugins/kibana/public/settings/index.js
src/plugins/kibana/public/settings/sections/about/index.js
src/plugins/kibana/public/settings/sections/about/index.html
src/plugins/kibana/public/settings/sections/advanced/lib/to_editable_config.js
src/plugins/kibana/public/settings/sections/index.js
Expand Down Expand Up @@ -74,8 +75,9 @@ src/server/KbnServer.js

src/testUtils/stub_index_pattern.js

src/ui/index.js
src/ui/UiBundlerEnv.js

src/ui/public/chrome/api/angular.js
src/ui/public/Vis/VisType.js

src/ui/public/agg_table/agg_table.js
Expand Down Expand Up @@ -164,6 +166,7 @@ tasks/build/installNpmDeps.js
tasks/build/pleaserun.js
tasks/build/run.js
tasks/build/versionedLinks.js
tasks/build/packageJson.js

tasks/config/copy.js
tasks/config/platforms.js
Expand Down
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"SPARQL"
],
"private": false,
"version": "0.3.2",
"version": "4.4.1",
"kibi_version": "0.3.2",
"build": {
"number": 8467,
"sha": "6cb7fec4e154faa0a4a3fee4b33dfef91b9870d9"
Expand Down
4 changes: 2 additions & 2 deletions src/plugins/kibana/public/settings/sections/about/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ <h2>Kibi</h2>
<table class="table table-condensed kbn-settings-about-versions">
<tr>
<td>Version</td>
<td>{{kbnVersion}}</td>
<td>{{kibiVersion}}</td>
</tr>

<tr>
Expand All @@ -26,7 +26,7 @@ <h2>Kibi</h2>

<tr>
<td>Powered by</td>
<td><a href="https://www.elastic.co/blog/kibana-4-4-1-and-4-3-2-and-4-1-5">Kibana 4.4.1</a></td>
<td><a href="https://www.elastic.co/blog/kibana-4-4-1-and-4-3-2-and-4-1-5">Kibana {{kbnVersion}}</a></td>
</tr>

</table>
Expand Down
3 changes: 2 additions & 1 deletion src/plugins/kibana/public/settings/sections/about/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,9 @@ define(function (require) {
});

require('ui/modules').get('apps/settings')
.controller('settingsAbout', function ($scope, kbnVersion, buildNum, buildSha) {
.controller('settingsAbout', function ($scope, kbnVersion, kibiVersion, buildNum, buildSha) {
$scope.kbnVersion = kbnVersion;
$scope.kibiVersion = kibiVersion; // kibi: added to manage kibi version
$scope.buildNum = buildNum;
$scope.buildSha = buildSha;
});
Expand Down
1 change: 1 addition & 0 deletions src/server/KbnServer.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = class KbnServer {
constructor(settings) {
this.name = pkg.name;
this.version = pkg.version;
this.kibi_version = pkg.kibi_version; // kibi: added to manage kibi version
this.build = pkg.build || false;
this.rootDir = rootDir;
this.settings = settings || {};
Expand Down
1 change: 1 addition & 0 deletions src/server/config/schema.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const randomBytes = require('crypto').randomBytes;
module.exports = () => Joi.object({
pkg: Joi.object({
version: Joi.string().default(Joi.ref('$version')),
kibi_version: Joi.string().default(Joi.ref('$kibi_version')), // kibi: added to manage kibi version
buildNum: Joi.number().default(Joi.ref('$buildNum')),
buildSha: Joi.string().default(Joi.ref('$buildSha')),
}).default(),
Expand Down
2 changes: 2 additions & 0 deletions src/ui/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ module.exports = async (kbnServer, server, config) => {
bundlerEnv.addContext('urlBasePath', config.get('server.basePath'));
bundlerEnv.addContext('sourceMaps', config.get('optimize.sourceMaps'));
bundlerEnv.addContext('kbnVersion', config.get('pkg.version'));
bundlerEnv.addContext('kibiVersion', config.get('pkg.kibi_version')); // kibi: added to manage kibi version
bundlerEnv.addContext('buildNum', config.get('pkg.buildNum'));
uiExports.addConsumer(bundlerEnv);

Expand Down Expand Up @@ -73,6 +74,7 @@ module.exports = async (kbnServer, server, config) => {
app: app,
nav: uiExports.apps,
version: kbnServer.version,
kibi_version: kbnServer.kibi_version, // kibi: added to manage kibi version
buildNum: config.get('pkg.buildNum'),
buildSha: config.get('pkg.buildSha'),
basePath: config.get('server.basePath'),
Expand Down
1 change: 1 addition & 0 deletions src/ui/public/chrome/api/angular.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ module.exports = function (chrome, internals) {

kibana
.value('kbnVersion', internals.version)
.value('kibiVersion', internals.kibi_version) // kibi: added to manage kibi version
.value('buildNum', internals.buildNum)
.value('buildSha', internals.buildSha)
.value('sessionId', Date.now())
Expand Down
2 changes: 1 addition & 1 deletion src/ui/views/ui_app.jade
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ block content
&nbsp;is loading. Give me a moment here. I'm loading a whole bunch of code. Don't worry, all this good stuff will be cached up for next time!
br
small
span Version [#{kibanaPayload.version}] - Powered by
span Version [#{kibanaPayload.kibi_version}] - Powered by
a(href="https://www.elastic.co/blog/kibana-4-4-1-and-4-3-2-and-4-1-5") Kibana 4.4.1


Expand Down
1 change: 1 addition & 0 deletions tasks/build/packageJson.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ module.exports = function (grunt) {
description: pkg.description,
keywords: pkg.keywords,
version: pkg.version,
kibi_version: pkg.kibi_version, // kibi: added to manage kibi version
build: {
number: grunt.config.get('buildNum'),
sha: grunt.config.get('buildSha')
Expand Down
2 changes: 1 addition & 1 deletion tasks/config/platforms.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module.exports = function (grunt) {
let { resolve } = require('path');

let version = grunt.config.get('pkg.version');
let version = grunt.config.get('pkg.kibi_version'); // kibi: use kibi version instead of kibana one
let nodeVersion = grunt.config.get('nodeVersion');
let rootPath = grunt.config.get('root');
let baseUri = `https://nodejs.org/dist/v${nodeVersion}`;
Expand Down

0 comments on commit da02cd1

Please sign in to comment.