Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add auto dependency checker #9

Merged
merged 2 commits into from
May 17, 2022
Merged

add auto dependency checker #9

merged 2 commits into from
May 17, 2022

Conversation

dyuliu
Copy link
Contributor

@dyuliu dyuliu commented May 12, 2022

No description provided.

@dyuliu dyuliu requested a review from frances-h May 12, 2022 11:49
Copy link

@frances-h frances-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that's missing is the tests/requirements_files/latest_requirements.txt file which is used to track what the known latest version of dependencies are. You can auto generate this file by running make checkdeps OUTPUT_PATH=tests/requirement_files/latest_requirements.txt from the repo's base directory.

@dyuliu
Copy link
Contributor Author

dyuliu commented May 12, 2022

One thing that's missing is the tests/requirements_files/latest_requirements.txt file which is used to track what the known latest version of dependencies are. You can auto generate this file by running make checkdeps OUTPUT_PATH=tests/requirement_files/latest_requirements.txt from the repo's base directory.

That's a good catch. We have to create an initial version to start with.

@dyuliu dyuliu merged commit 58c87b4 into master May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants