add _DELIMITER_ to split env and uselessheader #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverwind
reviewed
Jun 19, 2018
index.js
Outdated
| if (line !== '') { | ||
| const parts = line.split('='); | ||
| ret[parts.shift()] = parts.join('='); | ||
| } |
There was a problem hiding this comment.
Suggestion:
for (const line of stripAnsi(env).split('\n').filter(line => !!line)) {There was a problem hiding this comment.
Hi, I just test this code, but afternpm test, it throws:
index.js:12:63
✖ 12:63 use Boolean(line) instead. no-implicit-coercion
so how about :
for (const line of stripAnsi(env).split('\n').filter(line => Bealoon(line))) {
There was a problem hiding this comment.
Ah, yes. Boolean(line) instead of !!line.
silverwind
reviewed
Jun 19, 2018
index.js
Outdated
| } | ||
|
|
|
LGTM once you resolve above comments. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sorry for last bad pull request, I add DELIMITER to split env and useless header for your last comment.