Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You regex allows leading zeroes #2

Closed
FabienDehopre opened this issue Jul 17, 2014 · 3 comments
Closed

You regex allows leading zeroes #2

FabienDehopre opened this issue Jul 17, 2014 · 3 comments

Comments

@FabienDehopre
Copy link

The regex allows leading zeroes in the major, minor and patch component of the version which is not allowed:

A normal version number MUST take the form X.Y.Z where X, Y, and Z are non-negative integers, and MUST NOT contain leading zeroes.

-- http:https://semver.org/
@FabienDehopre
Copy link
Author

You may replace the \d by [1-9]|[1-9][0-9]+

sindresorhus added a commit that referenced this issue Jul 19, 2014
@sindresorhus
add failing tests for #2
18ea9db
@sindresorhus
Copy link
Owner

Nice catch :)

Would you be interested in doing a PR?

@FabienDehopre
Copy link
Author

OK. I will do a PR...

@FabienDehopre FabienDehopre mentioned this issue Jul 19, 2014
Closed
sindresorhus pushed a commit that referenced this issue Jul 20, 2014
@sindresorhus
Close GH-3: fix issue allowing leading zeroes in major, minor and pat…
795b056 
…ch. Fixes #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FabienDehopre @sindresorhus